Esme Povirk (@madewokherd) commented about dlls/windowscodecs/metadataquery.c:
- TRACE("get_token error %#lx\n", hr); - return hr; + if (!(s = CoTaskMemAlloc(size))) + return E_OUTOFMEMORY; + memcpy(s, str, size); + + var->pwszVal = s; + var->vt = VT_LPWSTR; + return S_OK; } - elem->len = (end - start + 1) + next_elem.len;
- TRACE("id %s [%d]\n", wine_dbgstr_wn(elem->str, elem->len), *idx); +static void parse_query_name(struct query_parser *parser, PROPVARIANT *item) +{ + struct string_t span; As far as I can tell, you're not meaningfully using this struct. The `len` field isn't the length of the input string because it doesn't include `\` characters used for escaping. I think you'd be better off with individual locals.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7329#note_94520