28 May
2024
28 May
'24
8:52 p.m.
On Thu Apr 25 03:48:52 2024 +0000, Alex Henrie wrote:
I've modified the calls to SetupDiGetClassDescriptionA to pass all valid arguments. Changing `ls != ERROR_FILE_NOT_FOUND` to `ls == ERROR_INSUFFICIENT_BUFFER` or `ls == ERROR_MORE_DATA` in the implementation would cause the revised tests to fail. Sorry, that should be "(!ls || ls == ERROR_MORE_DATA)".
The point is that special-casing ERROR_FILE_NOT_FOUND looks wrong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5490#note_68810