Re: [PATCH v5 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/shell32/shlview_cmenu.c:
> +    }
> +    full_pidl = ILCombine(This->pidl, This->apidl[0]);
> +    if (!full_pidl)
> +    {
> +        ERR("Out of Memory\n");
> +        return;
> +    }
> +
> +    hr = IShellLinkW_SetIDList(shelllink, full_pidl);
> +    ILFree(full_pidl);
> +    if (FAILED(hr)) {
> +        ERR("SetIDList failed\n");
> +        return;
> +    }
> +    _ILSimpleGetTextW(This->apidl[0], (LPVOID)wszFilename, MAX_PATH);
> +    length = lstrlenW(wszFilename) + lstrlenW(shortcutW);
> `wcslen()`, but note that this check could lead to `wszLinkFilename` overflowing (howevever if we switch to dynamic allocation this will likely change anyway).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_71734