16 Feb
2024
16 Feb
'24
7:12 a.m.
On Thu Feb 15 22:52:58 2024 +0000, Giovanni Mascellani wrote:
This feels fragile: if in the future somewhere else `r1` is used and `temp_idx = 2` is put somewhere else, then the reference `r1` becomes illegal. Maybe setting `temp_idx` should filter with a `max()` and be moved inside `instruction_dst_param_init_temp_vector()`? So long as values are extracted immediately, and temps elsewhere are only used to construct src params, there can be no temp register conflicts.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/629#note_61432