From: Francois Gouget <fgouget(a)codeweavers.com> When they contain a percent character they would, at best, not be printed correctly, and at worst cause a crash. --- Or maybe even cause an exploitable buffer overflow but that's not much of a concern in this case. --- programs/winetest/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 74b596b237b..2fbeda572dd 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -1122,7 +1122,7 @@ run_tests (char *logname, char *outdir) logfile = create_temp_file( tmpname ); logname = tmpname; } - report (R_OUT, logname); + report (R_OUT, "%s",logname); if (logfile == INVALID_HANDLE_VALUE) report (R_FATAL, "Could not open logfile: %u", GetLastError()); @@ -1148,7 +1148,7 @@ run_tests (char *logname, char *outdir) if (!newdir && (!outdir || GetLastError() != ERROR_ALREADY_EXISTS)) report (R_FATAL, "Could not create directory %s (%d)", tempdir, GetLastError()); - report (R_DIR, tempdir); + report (R_DIR, "%s", tempdir); xprintf ("Version 4\n"); xprintf ("Tests from build %s\n", build_id[0] ? build_id : "-" ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2180