Re: [PATCH v3 0/2] MR2821: wined3d: Improve d3d8 compatibility of minification and magnification filters.

[Stefan Dösinger]

Stefan Dösinger (@stefan) commented about dlls/d3d8/device.c:
> hr = wined3d_device_validate_device(device->wined3d_device, pass_count);
>      wined3d_mutex_unlock();
>
> +    /* In d3d8, texture filters are not validated, so errors concerning
> +     * unsupported ones are ignored here. */
> +    if (hr == WINED3DERR_UNSUPPORTEDTEXTUREFILTER) {
> +        *pass_count = 1;
> +        return D3D_OK;
> +    }

Two small requests here: Please follow the code style of the rest of the file (put the { on its own line), and print a WARN message, e.g. WARN("Ignoring invalid texture filter settings.\n");

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2821#note_33092