Re: [PATCH v6 1/2] winmm: Always call MCI_UnmapMsgAtoW in mciSendCommandA.

[Dmitry Timoshkov]

Alistair Leslie-Hughes <wine(a)gitlab.winehq.org> wrote:
> @@ -2294,8 +2293,8 @@ DWORD WINAPI mciSendCommandA(MCIDEVICEID wDevID, UINT wMsg, DWORD_PTR dwParam1,
>          return MCIERR_OUT_OF_MEMORY;
>      }
>      ret = mciSendCommandW(wDevID, wMsg, dwParam1, dwParam2);
> -    if (mapped)
> -        MCI_UnmapMsgAtoW(wMsg, dwParam1, dwParam2, ret);
> +
> +    MCI_UnmapMsgAtoW(wMsg, dwParam1, dwParam2, ret);
>      return ret;
>  }

Probably use of an intermediate local variable 'mapped' could be also eliminated.

-- 
Dmitry.