29 Jan
2025
29 Jan
'25
10:46 p.m.
On Wed Jan 29 22:46:11 2025 +0000, eric pouech wrote:
it doesn't make sense to pass ¬atestfile when expected status isn't STATUS_SUCCESS IOW, all tests with expected_status != STATUS_SUCCESS should have NULL as expected filename (actually, we could even think that for the expected_status == STATUS_SUCCESS case, the expected filename isn't NULL, but that would requires some more work as a NULL mask generates other filenames starting with "." and "..") You're absolutely right, in the case where status isn't STATUS_SUCCESS the name check is never done, so there is no point in passing it in at all. I'll correct this and replace it with NULL.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_93240