Re: [PATCH 0/1] MR8949: dxcore: Hold a critical section when interacting with the global factory.

10 Sep 2025


      On Wed Sep 10 18:01:43 2025 +0000, Nikolay Sivov wrote:
...
It's not caused by your change, but one awkward thing is that calling
with wrong IID will create a factory with 0 refcount and function will
return leaving it like that. I think it's better to set global pointer
only on success. It will get bumped to 1 on first successful call, but
still having a live object with refcount == 0 is not intuitive.
Looks like native just returns E_NOINTERFACE for the wrong IID. May as well just check that up front and bail early, right?
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8949#note_115582

Re: [PATCH 0/1] MR8949: dxcore: Hold a critical section when interacting with the global factory.

Tim Clem (＠tclem)