Rémi Bernon (@rbernon) commented about dlls/opengl32/wgl.c:
+ case WGL_TRANSPARENT_BLUE_VALUE_ARB: return fmt->transparent_blue_value; + case WGL_TRANSPARENT_ALPHA_VALUE_ARB: return fmt->transparent_alpha_value; + case WGL_TRANSPARENT_INDEX_VALUE_ARB: return fmt->transparent_index_value; + case WGL_SAMPLE_BUFFERS_ARB: return fmt->sample_buffers; + case WGL_SAMPLES_ARB: return fmt->samples; + case WGL_BIND_TO_TEXTURE_RGB_ARB: return fmt->bind_to_texture_rgb; + case WGL_BIND_TO_TEXTURE_RGBA_ARB: return fmt->bind_to_texture_rgba; + case WGL_BIND_TO_TEXTURE_RECTANGLE_RGB_NV: return fmt->bind_to_texture_rectangle_rgb; + case WGL_BIND_TO_TEXTURE_RECTANGLE_RGBA_NV: return fmt->bind_to_texture_rectangle_rgba; + case WGL_FRAMEBUFFER_SRGB_CAPABLE_ARB: return fmt->framebuffer_srgb_capable; + case WGL_FLOAT_COMPONENTS_NV: return fmt->float_components; + default: FIXME( "unsupported 0x%x WGL attribute\n", attrib ); + } + + return 0; +} I think explicit break / return on default cases is better, avoids accidental fallthroughs (even though it can cause a warning).
```suggestion:-4+0 default: FIXME( "unsupported 0x%x WGL attribute\n", attrib ); return 0; } } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5844#note_73174