17 Jul
2022
17 Jul
'22
8:35 p.m.
On Sun Jul 17 20:29:40 2022 +0000, Robert Wilhelm wrote:
Hi Esme, thanks for the review. Yes, I could check for MoveFileW error here. However MoveFileW will return FILENOTFOUND for non-existing source, but I need to return PATHNOTFOUND in this case. Therefore I cannot use create_error if MoveFileW fails. I hadn't seen the later patches when I wrote that comment. I'm not sure if it's possible to have this only work for folders without doing a separate check anyway.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/391#note_4494