22 Jan
2024
22 Jan
'24
6:33 p.m.
Esme Povirk (@madewokherd) commented about dlls/gdiplus/image.c:
+ + if (effect->type == RedEyeCorrectionEffect) + { + if ((paramsize-size > 0) || (((size-paramsize)%sizeof(RECT)) != 0)) + return InvalidParameter; + } + else + { + if (paramsize != size) + return InvalidParameter; + } + + switch (effect->type) + { + case BlurEffect: + alloc_copy(params, effect->p.blurparams, size); I think this will leak memory if parameters were already set.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58437