31 Jan
2024
31 Jan
'24
10:50 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
}
texture_type: - KW_TEXTURE1D + KW_BUFFER + { + $$ = HLSL_SAMPLER_DIM_BUFFER; + }
Unless I'm missing something, this means that it is not possible to, say, call `Sample()` on a buffer, which I'm not sure it's right. Could you please add a few tests checking that the various places in which we accept `HLSL_TYPE_TEXTURE` types also make sense with buffers? It might be the occasion to convert `add_*_method_call()` to a positive logic rather than the current negative logic that some of those functions have. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569#note_59590