24 Apr
2023
24 Apr
'23
7:34 a.m.
Hans Leidekker (@hans) commented about dlls/winhttp/session.c:
switch (option) { + case WINHTTP_OPTION_PARENT_HANDLE: + { + if (!validate_buffer( buffer, buflen, sizeof(HINTERNET) )) return FALSE; + + *(HINTERNET *)buffer = ((struct object_header *)request->connect)->handle;
Thanks for the patch. You can avoid the cast like this: ``` *(HINTERNET *)buffer = request->connect->hdr.handle; ``` Please also remove the cast from connect_query_option(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2697#note_30977