Re: [PATCH v3 0/8] MR4284: msvcrt: Add implementation and fixes to localize functions

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/mbcs.c:
> *
>   * Compare two multibyte strings case insensitively to 'len' characters.
>   */
> -int CDECL _mbsnicmp(const unsigned char* str, const unsigned char* cmp, size_t len)
> +int CDECL _mbsnicmp_l(const unsigned char* str, const unsigned char* cmp, size_t len, _locale_t locale)
>  {
> -  /* FIXME: No tolower() for mb strings yet */
> -  if(get_mbcinfo()->ismbcodepage)
> -  {
> -    unsigned int strc, cmpc;
> -    while(len--)
> +    pthreadmbcinfo mbcinfo;
> +
> +    if (!MSVCRT_CHECK_PMT(str && cmp))
> It also breaks `len == 0` case.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4284#note_50996