11 Oct
2023
11 Oct
'23
7:47 p.m.
``` Subject: [PATCH 1/6] vkd3d-shader/tpf: Remove unnecessary fallthrough (clangd). ```
What is the issue here exactly? I don't necessarily have an issue with the change, but I wouldn't say it's an improvement purely on its own merits either.
```diff #include "hlsl.h" +#include "vkd3d_shader.h" #include <stdio.h> ```
Is that needed? Doesn't hlsl.h pull in vkd3d_shader_private.h, which pulls in vkd3d_shader.h?
``` Subject: [PATCH 4/6] vkd3d-shader/hlsl: Remove enum hlsl_error_level. ```
We might as well merge that with the preceding patch that removes the last users of these. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/402#note_48383