28 May
2024
28 May
'24
9:06 p.m.
Jinoh Kang (@iamahuman) commented about programs/explorer/desktop.c:
} name = next; } + SetLastError( ERROR_SUCCESS );
How does this fix the bug? The bug is about SetEnvironmentVariableW. It's not about a program that indirectly uses it (explorer). If I changed this line to `SetLastError( -1 );` or `SetLastError( -GetLastError() );`, does it cause anything? I see nothing that relies on the last error value from this point onward. Again, I don't see how this fixes bug #50553 or anything related. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5574#note_69545