21 Mar
2024
21 Mar
'24
3:24 p.m.
Right, well as things have changed a lot since then as we now have loops anyway everywhere, what about merging the seq lock within it, like this: https://gitlab.winehq.org/rbernon/wine/-/commit/6897f75798835c3a0bf2e2c7f428...
Looks fine, although I'd use `STATUS_PENDING` instead of `STATUS_RETRY /* return STATUS_RETRY to enter reader loops */`. Also perhaps we want to pass-through NTSTATUS from `get_thread_session_object_info` instead of discarding it, so that we can return things like `0xc0010000 | ERROR_INVALID_WINDOW_HANDLE`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_65635