17 Jul
2024
17 Jul
'24
2:20 p.m.
Jacek Caban (@jacek) commented about dlls/mshtml/htmlevent.c:
static HRESULT WINAPI DOMEvent_put_cancelBubble(IDOMEvent *iface, VARIANT_BOOL v) { DOMEvent *This = impl_from_IDOMEvent(iface); - FIXME("(%p)->(%x)\n", This, v); - return E_NOTIMPL; + + TRACE("(%p)->(%x)\n", This, v); + + if(This->phase < 2) + return S_OK; + + return DOMEvent_stopPropagation(&This->IDOMEvent_iface); What if `v` is false (and yeah, `IHTMLEventObj` probably got it wrong too)?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6096#note_76418