Re: [PATCH v3 0/1] MR8456: urlmon: Add PersistentZoneIdentifier COM object stubs

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/urlmon/zone_id.c:
> +    PZIZoneId_GetId,
> +    PZIZoneId_SetId,
> +    PZIZoneId_Remove
> +};
> +
> +HRESULT PersistentZoneIdentifier_Construct(IUnknown *outer, LPVOID *ppobj)
> +{
> +
> +    PersistentZoneIdentifier *ret;
> +
> +    TRACE("(%p %p)\n", outer, ppobj);
> +
> +    URLMON_LockModule();
> +
> +    ret = malloc(sizeof(PersistentZoneIdentifier));
> +    if (!ret) { return E_OUTOFMEMORY; }
> `URLMON_LockModule` shouldn't be called in the error case, so move it after the error handling. Also, please drop the brackets from the single-statement `if`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8456#note_108488