Chip Davis (@cdavis5e) commented about dlls/mmdevapi/tests/render.c:
broken(hr == E_NOINTERFACE) /* win8 */, "Failed to query IAudioClient3 interface: %08lx\n", hr);
- if(hr == S_OK) + if(hr == S_OK){ + UINT32 default_period, unit_period, min_period, max_period; + + hr = IAudioClient3_GetSharedModeEnginePeriod( + ac3, pwfx, &default_period, &unit_period, &min_period, &max_period); + ok(hr == S_OK, "GetSharedModeEnginePeriod returns %08lx\n", hr); + + if(hr == S_OK){
This `if` would only be necessary if `IAudioClient3::InitializeSharedAudioStream()` were expected to crash if `IAudioClient3::GetSharedModeEnginePeriod()` failed. It's probably safe to remove it. (Not the statements inside, just the condition.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3554#note_42132