Re: [PATCH v2 0/6] MR3528: winegstreamer: Implement windows api frontend for file media sink.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
> -    return E_NOTIMPL;
> +    if (media_sink_get_stream_sink_by_id(media_sink, stream_sink_id))
> +        return MF_E_STREAMSINK_EXISTS;
> +
> +    if (FAILED(hr = stream_sink_create(stream_sink_id, media_type, media_sink, &object)))
> +    {
> +        WARN("Failed to create stream sink, hr %#lx.\n", hr);
> +        return hr;
> +    }
> +
> +    EnterCriticalSection(&media_sink->cs);
> +    list_add_tail(&media_sink->stream_sinks, &object->entry);
> +    LeaveCriticalSection(&media_sink->cs);
> +
> +    if (stream_sink)
> +        IMFStreamSink_AddRef(*stream_sink = &object->IMFStreamSink_iface);
        IMFStreamSink_AddRef((*stream_sink = &object->IMFStreamSink_iface));

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3528#note_41755