17 May
2023
17 May
'23
11:44 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
var = store->lhs.var; if (!var->first_write) var->first_write = loop_first ? min(instr->index, loop_first) : instr->index; - store->rhs.node->last_read = instr->index; + store->rhs.node->last_read = last_read; if (store->lhs.offset.node)
Again not onto this MR, but maybe we could assert here that the path in all `hlsl_deref`'s is null, mostly as a justification to the reader possibly questioning why we're not extending the `last_read` there too. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/208#note_32992