7 Feb
2023
7 Feb
'23
9:25 a.m.
Giovanni Mascellani (@giomasce) commented about dlls/ntdll/unix/signal_arm.c:
"str r6, [r5, #0x80]\n\t" #endif "sub sp, sp, #0x160\n\t" /* sizeof(struct syscall_frame) + registers */ - "ldr r5, [r4, #0x1d8]\n\t" /* arm_thread_data()->syscall_frame */
All these hardcoded offsets feel quite fragile to me. Maybe it would be better to use [some technique like this](https://gitlab.winehq.org/giomasce/wine/-/blob/1501bca0da02980a5fa76b3c6c882...) to have the compiler copy around offsets for us. Just a comment, though, it's definitely out of scope for this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1088#note_23290