Re: [PATCH 0/2] MR4199: gdiplus: Fix implementation of GdipSetPenTransform

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/gdiplus/pen.c:
> GpStatus WINGDIPAPI GdipSetPenTransform(GpPen *pen, GpMatrix *matrix)
>  {
> -    static int calls;
> +    BOOL result;
>
> TRACE("(%p, %s)\n", pen, debugstr_matrix(matrix));
>
> if(!pen || !matrix)
>          return InvalidParameter;
>
> -    if(!(calls++))
> -        FIXME("(%p,%p) Semi-stub\n", pen, matrix);
> -
> +    GdipIsMatrixInvertible(matrix, &result);
> +    if (!result)
> +        return InvalidParameter;
> This is still a stub, isn't it? My understanding is that the transform is supposed to affect rendering, and it currently doesn't.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4199#note_49977