Re: [PATCH 0/2] MR6335: winsock: Support IPV4 UDP broadcast on connected socket without SO_BROADCAST.

[David Gow (＠sulix)]

David Gow (@sulix) commented about server/sock.c:
> ret = connect( unix_fd, &unix_addr.addr, unix_len );
>          }
>
> +        if (ret < 0 && errno == EACCES && sock->state == SOCK_CONNECTIONLESS && unix_addr.addr.sa_family == AF_INET
> +            && unix_addr.in.sin_addr.s_addr == htonl( INADDR_BROADCAST ))

Does this need to also handle other broadcast subnets? e.g., for the 192.168.0.0/24 subnet, 192.168.255.255?

This doesn't affect Age of Empires / BattleServer (which always uses INADDR_BROADCAST/255.255.255.255), but could potentially be an issue on other applications. It is a lot more work, though…

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6335#note_79553