13 Apr
2025
13 Apr
'25
1:42 a.m.
Esme Povirk (@madewokherd) commented about dlls/windowscodecs/pngformat.c:
+ else + { + BYTE *ptr = data; + for (int i = 0; i < value.caui.cElems; ++i, ptr += 2) + value.caui.pElems[i] = read_ushort_be(ptr); + } + } + else + { + hr = WINCODEC_ERR_BADMETADATAHEADER; + } + + free(data); + + if (SUCCEEDED(hr)) + hr = create_bkgd_item(&value, &result); I think if this fails, it doesn't take ownership of `value`, and `value` will need to be freed.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7795#note_100704