2 Nov
2022
2 Nov
'22
4:15 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxbc.c:
return ret; break;
+ case TAG_DXIL: + desc->is_dxil = true; + /* fall through */
It's mostly a theoretical thing, but if a shader has both a `DXIL` and a `SHDR` section it might end up with `is_dxil` set, but `byte_code` pointing to the TPF code. I would just write something like `desc->is_dxil = tag == TAG_DXIL;`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44#note_12816