Re: [PATCH 0/3] MR1079: wininet/netprofm: Connectivity improvements.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/wininet/internet.c:
> +        if (SUCCEEDED(INetworkListManager_GetConnectivity(mgr, &connectivity)) &&
> +            connectivity != NLM_CONNECTIVITY_DISCONNECTED)
> +        {
> +            if (SUCCEEDED(INetworkListManager_IsConnectedToInternet(mgr, &connected)) && connected)
> +            {
> +                WARN("always returning LAN connection.\n");
> +                status |= INTERNET_CONNECTION_LAN;
> +            }
> +            else
> +            {
> +                status |= INTERNET_CONNECTION_OFFLINE;
> +            }
> +        }
> +        INetworkListManager_Release(mgr);
>      }
> +    CoUninitialize();
> `CoInitialize()` may fail (eg. for MTAs) and then you will do an unmatched `CoUninitialize()` call. You could check `CoInitialize()` result, but I'm not sure why you use `CLSID_NetworkListManager` at all. Could we just use `GetAdaptersAddresses` directly instead?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1079#note_11059