Re: [PATCH 0/5] MR1588: Draft: Add windows.system.profile.systemmanufacturers DLL.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/windows.system.profile.systemmanufacturers/main.c:
> +}
> +
>  static HRESULT WINAPI statics_get_SerialNumber( ISmbiosInformationStatics *iface, HSTRING *value )
>  {
> -    FIXME( "iface %p, value %p stub!\n", iface, value );
> -    return E_NOTIMPL;
> +    WCHAR *serial;
> +    HSTRING ret;
> +    HRESULT hr;
> +    char *buf;
> +    UINT len;
> +
> +    TRACE( "iface %p, value %p.\n", iface, value );
> +
> +    len = GetSystemFirmwareTable( RSMB, 0, NULL, 0 );
> +    if (!(buf = HeapAlloc( GetProcessHeap(), 0, len )))
> Please don't use `HeapAlloc`, prefer standard C functions. Same goes elsewhere for `heap_` functions.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1588#note_17877