28 Feb
2024
28 Feb
'24
7:33 a.m.
Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
+ in_degrees[i] = UINT_MAX; + continue; + } + + in_degrees[i] = block->predecessors.count; + + /* Do not count back edges. */ + if (cfg->loops_by_header[i]) + { + assert(in_degrees[i] > 0); + in_degrees[i] -= 1; + } + + if (in_degrees[i] == 0 && block != cfg->entry) + { + ERR("Unexpected entry point %u.\n", block->label); Is this more accurately a `FIXME`? We don't normally emit `ERR` because a shader is invalid. Ditto for the entry point check after the loop.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/672#note_62886