24 Oct
2022
24 Oct
'22
1:39 p.m.
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/propsheet.c:
for (n = i = 0; i < lppsh->nPages; i++, n++) { if (!psInfo->usePropPage) - psInfo->proppage[n].hpage = psInfo->ppshheader.u3.phpage[i]; + { + if (psInfo->ppshheader.u3.phpage[i] && + psInfo->ppshheader.u3.phpage[i]->magic == HPROPSHEETPAGE_MAGIC) + { + psInfo->proppage[n].hpage = psInfo->ppshheader.u3.phpage[i]; + } + else + { + psInfo->proppage[n].hpage = CreatePropertySheetPageA( + (const PROPSHEETPAGEA*)psInfo->ppshheader.u3.phpage[i]); Minor style issues. Please add a space before *.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1122#note_11897