4 Jul
2023
4 Jul
'23
4:23 p.m.
On Tue Jul 4 16:19:37 2023 +0000, Rémi Bernon wrote:
Would you mind changing it to `ReadNoFence`? I think it's better as it is a relaxed atomic operation, and we only need the acquire semantic on the interlocked exchange. I think it's the last nitpick I have. FWIW on x86 it doesn't really matter, since reads are always atomic, and compiler can't re-arrange them due to the other atomics as you mentioned. But `ReadNoFence` is indeed correct for other architectures though.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3189#note_37824