27 Dec
2025
27 Dec
'25
7:53 p.m.
Hello Alex, thanks for the patch. Commits submitted should be in their final form, as concise, logical, independent changes. Fixup commits should be squashed with their parents, and commits should be given descriptive names. Please avoid unnecessary formatting changes in lines you aren't otherwise touching. Your commits should also build without warnings. You should be seeing a warning for declaration after statement, which style we don't use in Wine. Please also avoid pushing until you are sure, to the best of your ability, that your patches are ready to be reviewed and in their final form. Each push wastes CI resources and reviewer attention. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9832#note_126186