Re: [PATCH v6 0/6] MR4140: uxtheme/tests: Add some tests for OpenThemeData() with various app/class names.

[Zhiyi Zhang (＠zhiyi)]

On Wed Nov  8 14:24:10 2023 +0000, Dmitry Timoshkov wrote:
> > > +            cls = MSSTYLES_FindClass(tfActiveTheme, szAppName, szClassName);
> > > +        else
> > > +            cls = MSSTYLES_FindClass(tfActiveTheme, pszAppName, szClassName);
> >
> > Let's put these parse and find parts into a find_app_class() helper to
> > avoid code duplication. So that you don't need to make the same changes
> > twice in the patch set.
> >
> > Let's use "szAppName[0] ? szAppName : pszAppName" instead. It will
> > look cleaner.
> > Can this micro optimizations be made in a folow up patches?
> > Okay, if you feel strongly about changing it now.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4140#note_51507