15 Nov
2023
15 Nov
'23
11:09 p.m.
On Wed Nov 15 22:50:11 2023 +0000, Francisco Casas wrote:
When creating a node using a `hlsl_new_*()` function you also have to add it to the instruction block using `hlsl_block_add_instr()`, as you can see in other uses of `hlsl_new_float_constant()` in the same file. More complex functions such as `intrinsic_float_convert_arg()` and those that start with `add_` do it themselves, so they don't require to call `hlsl_block_add_instr()` afterwards. I wonder if it was copied from log/log10. I see I missed add_insrt() in these two. We probably could have an add_float_constant() helper.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/475#note_52447