21 Aug
2025
21 Aug
'25
7:59 p.m.
On Thu Aug 21 15:57:23 2025 +0000, Tres Finocchiaro wrote:
@julliard thanks for clarification. I've reverted the `HIGHENTROPYVA` portions of this MR and resolved the styling questions.
Unless both flags are set together, there shouldn't be any difference for the case of `.exe.so` binaries. So according to this information, the following code would influence readability only, do you wish to remove it, keep it, or code-comment it?
if (!disable_dynamicbase) { spec->dll_characteristics |= IMAGE_DLLCHARACTERISTICS_HIGH_ENTROPY_VA; }It's fine to keep it, but please try to follow the pattern of setting flags directly during option processing, like e.g. `--nxcompat` does it.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113529