Re: [PATCH 0/5] MR2988: uiautomationcore: Add support for raising in-process events.

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/uiautomationcore/uia_utils.c:
> heap_free(cache_req->pProperties);
>      heap_free(cache_req->pPatterns);
>  }
>
> HRESULT uia_cache_request_clone(struct UiaCacheRequest *dst, struct UiaCacheRequest *src)
>  {
> -    if (src->pViewCondition)
> -    {
> -        FIXME("Cache request condition cloning currently unimplemented\n");
> -        dst->pViewCondition = NULL;
> -    }
> +    HRESULT hr;
> +
> +    hr = uia_condition_clone(&dst->pViewCondition, src->pViewCondition);
> +    if (FAILED(hr))
> +        return hr;

This removes a NULL check, is NULL pViewCondition expected or not?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2988#note_34820