Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c:
+ UINT offset; + + if (!(hdr = find_smbios_entry( SMBIOS_TYPE_SYSTEM, buf, len ))) return NULL; + system = (const struct smbios_system *)hdr; + offset = (const char *)system - buf + system->hdr.length; + + return get_smbios_string( id, buf, offset, len ); +} + +static WCHAR *get_bios_system_serial( const char *buf, UINT len ) +{ + WCHAR *ret = get_bios_system_serial_string( 4, buf, len ); + if (!ret) return wcsdup( L"0" ); + return ret; +} + Please name the getter after the property: get_bios_serialnumber(). This can be simplified to: `static WCHAR *get_bios_serialnumber( const char *buf, UINT len ) { WCHAR *ret = get_bios_string( 4, buf, len ); if (!ret) return wcsdup( L"0" ); return ret; } ` Note that on Linux this will not get a different value because serial numbers are readable only by root.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1588#note_17991