16 Mar
2024
16 Mar
'24
9:44 a.m.
Jinoh Kang (@iamahuman) commented about server/winstation.c:
/* get the thread current desktop */ DECL_HANDLER(get_thread_desktop) { + struct desktop *desktop; struct thread *thread;
if (!(thread = get_thread_from_id( req->tid ))) return; reply->handle = thread->desktop; + reply->index = -1; + + if ((desktop = get_thread_desktop( thread, 0 ))) (commits) This function call sets error, which introduces behavioral change (and thus possibility of regression) of NtUserGetThreadDesktop().
The `get_thread_desktop()` call should thus be split into its own commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_64985