Re: [PATCH 0/5] MR98: hlsl: Matrix majority, 2023 edition.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
> else
>              default_majority = HLSL_MODIFIER_ROW_MAJOR;
>      }
> +    else if (type->type != HLSL_CLASS_MATRIX && (*modifiers & HLSL_MODIFIERS_MAJORITY_MASK))
> +    {
> +        hlsl_error(ctx, &loc, VKD3D_SHADER_ERROR_HLSL_INVALID_MODIFIER,
> +                "'row_major' and 'column_major' modifiers are only allowed for matrices.");
> +    }

Any reason for not reusing `check_invalid_matrix_modifiers()`?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/98#note_24540