21 Sep
2022
21 Sep
'22
9:15 p.m.
On Thu Sep 8 03:30:34 2022 +0000, Ziqing Hui wrote:
Do you mean `output_to_index`? `output_to_index` is used in `d2d_transform_graph_remove_node()`. If we don't record the index to which our node connects, in `d2d_transform_graph_remove_node()`, we have to replace: ``` if (node->output) node->output->inputs[node->output_to_index] = NULL; ``` with ``` if (node->output) { for (i = 0; i < node->output->input_count; ++i) { if (node->output->inputs[i] == node) { node->output->inputs[i] = NULL; break; } } } ``` Which one would be better? Remove `output_to_index` or not? (I didn't change this in v2.)
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/698#note_9024