23 May
2023
23 May
'23
1:43 a.m.
Huw Davies (@huw) commented about dlls/winepulse.drv/pulse.c:
+ } else { + params->result = AUDCLNT_E_UNSUPPORTED_FORMAT; + break; + } + + break; + } + + case WAVE_FORMAT_ALAW: + case WAVE_FORMAT_MULAW: + if (fmt->wBitsPerSample != 8) { + params->result = E_INVALIDARG; + break; + } + /* Fall-through */ + case WAVE_FORMAT_IEEE_FLOAT: Indenting the fall-through cases looks a bit odd. Also, I'd move the case labels so they line up with their `switch()` (we're a bit inconsistent about that in this file).
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2869#note_33488