10 Oct
2022
10 Oct
'22
1:45 p.m.
On Mon Oct 10 13:45:33 2022 +0000, Jinoh Kang wrote:
This change is however still backwards compatible with Linux since `sa_family` is of effective type `uint8_t` and `sa_len` is currently disregarded. This is only true on big-endian systems. Note that `sa_family` is in host endian, unlike other sockaddr fields. On little-endian systems, your change means that `sa_len` will take the place of the *lower* 8 bits of former `sa_family`. Endian issues aside, I think it's better not to be too clever on bit representations on general.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015#note_10121