Re: [PATCH 0/1] MR4530: d3drm: Set image->palette only once in d3drm_image_palettise (GCC).

28 Nov 2023


      On Tue Nov 28 16:18:08 2023 +0000, Matteo Bruni wrote:
...
So this also avoids the warning here:
```suggestion:-0+0
    image->palette = palette;
    if ((palette = realloc(palette, colour_count * sizeof(*palette))))
        image->palette = palette;
```
I'm leaving it up to the reviewers to decide if we want to be pedantic
like this :grinning:
I prefer this version, frankly (and I find it clearer than the current code anyway), though I'm also struggling to see why GCC complains about the one but not the other?
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4530#note_54131

Re: [PATCH 0/1] MR4530: d3drm: Set image->palette only once in d3drm_image_palettise (GCC).

Zebediah Figura (＠zfigura)