On Wed Dec 3 20:47:12 2025 +0000, Michael Stefaniuc wrote:
Hmm... Rémi pulling out of the review makes my life harder as he wrote the changed code. Anyway I have started testing the change with the my usual set of apps (mostly game demos). I was excited to no longer see ``` 0294:err:dmsynth:synth_sink_render_thread WaitForMultipleObjects returned 0 ``` but on a closer look that `ERR()` is most likely a forgotten quick debug line as `ret` 0 is just `WAIT_OBJECT_0`.\ The new code with `if (ret == WAIT_OBJECT_0)` is more readable in that regard. I need to do more testing and a / b comparison as not all my dmusic test apps make noise. But so far none of that crashed nor deadlocked. And I need to do a proper code review so I'll need a few days for this one. The first patch should provide the most impact on the playback quality. I can split it off into a separate MR if you think it'll have a greater chance to get in before the freeze.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9651#note_124709