8 Aug
2025
8 Aug
'25
5:20 a.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/d3dx_helpers.c:
if (src_data_size < expected_src_data_size) { WARN("File is too short %u, expected at least %u bytes.\n", src_data_size, expected_src_data_size); - return D3DXERR_INVALIDDATA; + /* D3DX10/D3DX11 do not validate the size of the pixels, only the header. */ + if (!(flags & D3DX_IMAGE_SUPPORT_DXT10)) + return D3DXERR_INVALIDDATA;
Do we want to do this? It's the kind of bug-for-bug compatibility that I'm not sure we should replicate, at least until some application comes up needing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8705#note_112443