21 Aug
2023
21 Aug
'23
6:52 p.m.
Bartosz Kosiorek (@gang65) commented about dlls/gdiplus/image.c:
bih.biClrImportant = 0;
screendc = CreateCompatibleDC(0); - if (iinfo.hbmColor) - { - GetDIBits(screendc, iinfo.hbmColor, 0, height, lockeddata.Scan0, (BITMAPINFO*)&bih, DIB_RGB_COLORS); + GetDIBits(screendc, iinfo.hbmColor, 0, height, lockeddata.Scan0, (BITMAPINFO*)&bih, DIB_RGB_COLORS);
Generally, we should checkout the return value of `GetDIBits`, like: ```suggestion:-0+0 if (GetDIBits(screendc, iinfo.hbmColor, 0, height, lockeddata.Scan0, (BITMAPINFO*)&bih, DIB_RGB_COLORS)) { ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3621#note_42897