Re: [PATCH v7 0/1] MR5904: Improve color mode and paper source detection

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/sane.ds/capability.c:
> if (twCC == TWCC_SUCCESS) {
>              if (reload) get_sane_params(&activeDS.frame_params);
> -            break;
>          }
>      }
>      return twCC;
>  }
>
> +static TW_UINT16 find_value_pos(const char* value, const char* values, TW_UINT16 buf_len, TW_UINT16 buf_count)
> +{
> +    TW_UINT16 index;
> +    for (index=0; index<buf_count; ++index)
> +    {
> +        if (!strcmp(value, values))
> +            return index;
> +        value += buf_len;

This doesn't seem right. I would expect that `value` is what we're searching for, and `values` should be modified.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5904#note_74143