22 Jan
2024
22 Jan
'24
5:14 p.m.
I'm not sure how much it matters, but I would have split the patches like this: First, implement PerformOperations along with one other method, so that PerformOperations can do something. Then implement the other methods in separate commits. That way, all of the commits make a functional change, and the related code for each function can be added in each commit. For example, the commit that implements NewItem can also introduce the new_item function. Since the way new_item works depends on the item that NewItem creates, it'd be easier to review them together. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4817#note_58422